CRO-169: also includes CRO-314 and CRO-179. Hide brands in the footer if #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcampa
reviewed
Jul 25, 2017
there are no brands, hide Info section in the footer if address isn't provided
bc-nataliya
force-pushed
the
CRO-169
branch
2 times, most recently
from
67be90e to
181082c
Compare
|
@bigcommerce/stencil-team |
junedkazi
reviewed
Jul 27, 2017
CHANGELOG.md
Outdated
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## Draft | |||
|
|
|||
| - Hide Info in footer if no address is provided in Store Profile. Hide Brands in footer if Merchant has no brands [#1053](https://github.com/bigcommerce/cornerstone/pull/1053) | |||
There was a problem hiding this comment.
Can you please remove the line between draft title & the change log line
junedkazi
reviewed
Jul 27, 2017
|
|
||
| {{#if settings.address}} |
There was a problem hiding this comment.
any reason for not checking this as Or ? What if only phone number exists ?
There was a problem hiding this comment.
if you enter phone number it will require you to enter address as well. No way to have only phone number.
mcampa
approved these changes
Jul 27, 2017
junedkazi
approved these changes
Jul 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Hide brands in the footer if there are no brands, hide Info section in the footer if address isn't provided
Tickets / Documentation
https://jira.bigcommerce.com/browse/CRO-314
https://jira.bigcommerce.com/browse/CRO-179
epic is here https://jira.bigcommerce.com/browse/CRO-9
Screenshots (if appropriate)
@junedkazi @mcampa please ping anyone else needed